linux-kernel - Re: [PATCH 2/2] drivers: iio: pressure: Sort headers of BMPxxx SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 24 Feb 2024 17:59:30 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Vasileios Amoiridis <vassilisamir@...il.com>, lars@...afoo.de,
 ang.iglesiasg@...il.com, linus.walleij@...aro.org,
 semen.protsenko@...aro.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers: iio: pressure: Sort headers of BMPxxx SPI
 driver

On Tue, 20 Feb 2024 21:56:15 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Tue, Feb 20, 2024 at 07:41:25PM +0100, Vasileios Amoiridis wrote:
> > Alphabetical sorting and separation of headers for the BMPxxx
> > SPI driver.  
> 
> ...
> 
> > -#include <linux/module.h>
> > -#include <linux/spi/spi.h>
> > +#include <linux/bits.h>
> >  #include <linux/err.h>
> > +#include <linux/module.h>
> >  #include <linux/regmap.h>  
> 
> > -#include <linux/bits.h>  
> 
> That's what I meant. Please do not add it into the wrong place to begin with.
> 
> > +#include <linux/spi/spi.h>  
> 

This isn't going be something I rush in with the fix, so
plenty of time to revisit this next cycle.

Thanks,

Jonathan