linux-kernel - Re: [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240224-coyness-civic-d583b863c614@spud>
Date: Sat, 24 Feb 2024 19:16:43 +0000
From: Conor Dooley <conor@...nel.org>
To: Zev Weiss <zev@...ilderbeest.net>
Cc: Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat
 strings

On Sat, Feb 24, 2024 at 02:37:07AM -0800, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
> 
> Signed-off-by: Zev Weiss <zev@...ilderbeest.net>

Oh sweet, I was just about to go off and write this patch - thanks!

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 4 ++--
>  arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> index 4554abf0c7cd..9aa2de3723b5 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> @@ -98,14 +98,14 @@ w83773g@4c {
>  
>  	/* IPB PMIC */
>  	lm25066@40 {
> -		compatible = "lm25066";
> +		compatible = "ti,lm25066";
>  		reg = <0x40>;
>  		shunt-resistor-micro-ohms = <1000>;
>  	};
>  
>  	/* 12VSB PMIC */
>  	lm25066@41 {
> -		compatible = "lm25066";
> +		compatible = "ti,lm25066";
>  		reg = <0x41>;
>  		shunt-resistor-micro-ohms = <10000>;
>  	};
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> index 6600f7e9bf5e..e830fec0570f 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> @@ -14,7 +14,7 @@ efuse##n {					\
>  
>  #define EFUSE(hexaddr, num)							\
>  	efuse@...exaddr {							\
> -		compatible = "lm25066";						\
> +		compatible = "ti,lm25066";					\
>  		reg = <0x##hexaddr>;						\
>  		shunt-resistor-micro-ohms = <675>;				\
>  		regulators {							\
> -- 
> 2.43.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)