linux-kernel - Re: [PATCH] exec: Remove unnecessary ‘NULL’ values from vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202402231703.8D5E862@keescook>
Date: Fri, 23 Feb 2024 17:04:44 -0800
From: Kees Cook <keescook@...omium.org>
To: Li zeming <zeming@...china.com>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, ebiederm@...ssion.com,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] exec: Remove unnecessary ‘NULL’ values from vma

On Tue, Feb 20, 2024 at 01:18:30PM +0800, Li zeming wrote:
> vma is assigned first, so it does not need to initialize the
> assignment.

I don't really like removing explicit initializations. They don't cause
any problems and the compiler will remove redundant stores, so there's
no benefit in dropping them.

-- 
Kees Cook