linux-kernel - Re: [PATCH v2 1/5] spi: add spi_optimize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f25b520-563c-4b3b-96cd-d1dcc7ea6f40@web.de>
Date: Sat, 24 Feb 2024 21:09:40 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: David Lechner <dlechner@...libre.com>, linux-spi@...r.kernel.org,
 linux-iio@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com, Mark Brown <broonie@...nel.org>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 David Jander <david@...tonic.nl>, Jonathan Cameron <jic23@...nel.org>,
 Martin Sperl <kernel@...tin.sperl.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Michael Hennerich <michael.hennerich@...log.com>,
 Nuno Sá <nuno.sa@...log.com>
Subject: Re: [PATCH v2 1/5] spi: add spi_optimize_message() APIs

…
> +++ b/drivers/spi/spi.c
…
> +static int __spi_optimize_message(struct spi_device *spi,
> +				  struct spi_message *msg)
…

I propose to reconsider the usage of leading underscores in such identifiers.

See also:
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus