linux-kernel - Re: [PATCH v2 2/3] mm, slab: use an enum to define SLAB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e2e6912-5778-2e34-5f63-3ccaebdbe576@google.com>
Date: Sat, 24 Feb 2024 13:02:09 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Vlastimil Babka <vbabka@...e.cz>
cc: Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>, 
    Joonsoo Kim <iamjoonsoo.kim@....com>, 
    Andrew Morton <akpm@...ux-foundation.org>, 
    Roman Gushchin <roman.gushchin@...ux.dev>, 
    Hyeonggon Yoo <42.hyeyoo@...il.com>, 
    Andrey Ryabinin <ryabinin.a.a@...il.com>, 
    Alexander Potapenko <glider@...gle.com>, 
    Andrey Konovalov <andreyknvl@...il.com>, 
    Dmitry Vyukov <dvyukov@...gle.com>, 
    Vincenzo Frascino <vincenzo.frascino@....com>, 
    Zheng Yejian <zhengyejian1@...wei.com>, 
    Xiongwei Song <xiongwei.song@...driver.com>, 
    Chengming Zhou <chengming.zhou@...ux.dev>, linux-mm@...ck.org, 
    linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com
Subject: Re: [PATCH v2 2/3] mm, slab: use an enum to define SLAB_ cache
 creation flags

On Fri, 23 Feb 2024, Vlastimil Babka wrote:

> The values of SLAB_ cache creation flags are defined by hand, which is
> tedious and error-prone. Use an enum to assign the bit number and a
> __SLAB_FLAG_BIT() macro to #define the final flags.
> 
> This renumbers the flag values, which is OK as they are only used
> internally.
> 
> Also define a __SLAB_FLAG_UNUSED macro to assign value to flags disabled
> by their respective config options in a unified and sparse-friendly way.
> 
> Reviewed-and-tested-by: Xiongwei Song <xiongwei.song@...driver.com>
> Reviewed-by: Chengming Zhou <chengming.zhou@...ux.dev>
> Reviewed-by: Roman Gushchin <roman.gushchin@...ux.dev>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>

Acked-by: David Rientjes <rientjes@...gle.com>