linux-kernel - Re: [PATCH v4] x86/coco: Require seeding RNG with RDRAND on CoCo systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 24 Feb 2024 02:14:55 +0100
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Tom Lendacky <thomas.lendacky@....com>
Cc: x86@...nel.org, linux-coco@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	Borislav Petkov <bp@...en8.de>, Daniel P . Berrangé <berrange@...hat.com>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, "H . Peter Anvin" <hpa@...or.com>, 
	Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, stable@...r.kernel.org, 
	Elena Reshetova <elena.reshetova@...el.com>, 
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>, "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH v4] x86/coco: Require seeding RNG with RDRAND on CoCo systems

Hi Tom,

On Fri, Feb 23, 2024 at 11:05 PM Tom Lendacky <thomas.lendacky@....com> wrote:
>
> On 2/21/24 20:05, Jason A. Donenfeld wrote:
> > +
> > +     if (cc_vendor == CC_VENDOR_NONE)
>
> I responded to an earlier version of this patch, adding that response here:
>
> You probably want to use:
>
>      if (!cc_platform_has(CC_GUEST_MEM_ENCRYPT))
>          return;
>
> Otherwise, you can hit the bare-metal case where AMD SME is active and
> then cc_vendor will not be CC_VENDOR_NONE.

Nice catch, thanks. I'll do that for v+1.


Jason