linux-kernel - Re: [PATCH v4 16/16] ARM: dts: imx6ull-uti260b: Add board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5CWQk8__qwHF8ysXnY4zAfd_FvW+Znd1sdoPc_uPJJE4A@mail.gmail.com>
Date: Sat, 24 Feb 2024 22:11:03 -0300
From: Fabio Estevam <festevam@...il.com>
To: Sebastian Reichel <sre@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, NXP Linux Team <linux-imx@....com>, 
	Dong Aisheng <aisheng.dong@....com>, Linus Walleij <linus.walleij@...aro.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Mark Brown <broonie@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH v4 16/16] ARM: dts: imx6ull-uti260b: Add board

On Sat, Feb 24, 2024 at 6:33 PM Sebastian Reichel <sre@...nel.org> wrote:

> +&gpio2 {
> +       /* configuring this to output-high results in poweroff */
> +       power-en-hog {
> +               gpio-hog;
> +               gpios = <6 GPIO_ACTIVE_HIGH>;
> +               line-name = "power-en-gpio";
> +               output-low;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&mux_poweroff2>;
> +       };
> +};
> +
> +&ecspi3 {

It is recommended to put the nodes in alphabetical order (except
iomuxc, which is the last one).

> +       mux_gc0308: gc0308grp {
> +               fsl,pins = <
> +                       MX6UL_PAD_CSI_MCLK__CSI_MCLK                    0x1e038
> +                       MX6UL_PAD_GPIO1_IO05__GPIO1_IO05                0x1b088
> +                       MX6UL_PAD_GPIO1_IO06__GPIO1_IO06                0x1b088
> +               >;
> +       };
> +
> +

There is an extra blank line here.

Reviewed-by: Fabio Estevam <festevam@...il.com>