linux-kernel - Re: [PATCH] staging: greybus: put macro in a do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHxc4bsFj1=VFVDWbdwo3W3CmSyPG1585p2zBePpsD9qy6VKdA@mail.gmail.com>
Date: Sun, 25 Feb 2024 15:19:49 +0530
From: Dileep Sankhla <dileepsankhla.ds@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, pure.logic@...us-software.ie, johan@...nel.org, 
	elder@...nel.org
Subject: Re: [PATCH] staging: greybus: put macro in a do - while loop

On Sun, Feb 25, 2024 at 2:26 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> Did you test build this?

Hello Greg,

Yes. No new warning/error was encountered on building the kernel.

> >  #define gb_loopback_attr(field, type)                                        \
> >  static ssize_t field##_show(struct device *dev,                              \
>
> Why did you only change one if you thought this was a valid change?

1. As per my C background, I think no other macros in the above source
code file need to be enclosed in a do - while loop.
2. I am writing the patch because of the Eudyptula Challenge, and I
have to fix "one coding style problem" in any of the files in
drivers/staging/. The above one was one of them.

Regards,
Dileep