linux-kernel - Re: [PATCH 2/2] serial: bcm63xx-uart: fix tx after conversion to uart_port_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 25 Feb 2024 17:14:49 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Jiri Slaby <jirislaby@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>
Subject: Re: [PATCH 2/2] serial: bcm63xx-uart: fix tx after conversion to
 uart_port_tx_limited()

On Sun, Feb 25, 2024 at 04:14:26PM +0100, Jonas Gorski wrote:
> When bcm63xx-uart was converted to uart_port_tx_limited(), it implicitly
> added a call to stop_tx(). This causes garbage to be put out on the
> serial console. To fix this, pass UART_TX_NOSTOP in flags, and manually
> call stop_tx() ourselves analogue to how a similar issue was fixed in
> commit 7be50f2e8f20 ("serial: mxs-auart: fix tx").
> 
> Fixes: d11cc8c3c4b6 ("tty: serial: use uart_port_tx_limited()")
> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>
> ---
>  drivers/tty/serial/bcm63xx_uart.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c
> index a3cefa153456..259fe5895032 100644
> --- a/drivers/tty/serial/bcm63xx_uart.c
> +++ b/drivers/tty/serial/bcm63xx_uart.c
> @@ -309,8 +309,8 @@ static void bcm_uart_do_tx(struct uart_port *port)
>  
>  	val = bcm_uart_readl(port, UART_MCTL_REG);
>  	val = (val & UART_MCTL_TXFIFOFILL_MASK) >> UART_MCTL_TXFIFOFILL_SHIFT;
> -
> -	pending = uart_port_tx_limited(port, ch, port->fifosize - val,
> +	pending = uart_port_tx_limited_flags(port, ch, UART_TX_NOSTOP,
> +		port->fifosize - val,
>  		true,
>  		bcm_uart_writel(port, ch, UART_FIFO_REG),
>  		({}));
> @@ -321,6 +321,9 @@ static void bcm_uart_do_tx(struct uart_port *port)
>  	val = bcm_uart_readl(port, UART_IR_REG);
>  	val &= ~UART_TX_INT_MASK;
>  	bcm_uart_writel(port, val, UART_IR_REG);
> +
> +	if (uart_tx_stopped(port))
> +		bcm_uart_stop_tx(port);
>  }
>  
>  /*
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:


- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot