linux-kernel - Re: WARNING: fs/proc/generic.c:173 __xlate_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 25 Feb 2024 19:27:35 +0300
From: Alexey Dobriyan <adobriyan@...il.com>
To: Stefan Wahren <wahrenst@....net>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: WARNING: fs/proc/generic.c:173 __xlate_proc_name

On Sun, Feb 25, 2024 at 11:47:30AM +0100, Stefan Wahren wrote:
> Hi Alexey,
> 
> Am 25.02.24 um 11:37 schrieb Alexey Dobriyan:
> > > WARNING: CPU: 0 PID: 429 at fs/proc/generic.c:173
> > > __xlate_proc_name+0x78/0x98 name 'R1/S1'
> > proc_mkdir() didn't find 'R1' directory.
> > 
> > In other words, you can't have slashes in irq names.
> we already came to the point in the discussion before (link in my last
> mail). The problem is no libgpiod user (userspace) is aware of this.

Changing '/' to '-' or '.' should be OK. Whatever you do, don't change
to '!' because it will make these paths annoying to use in bash.

> So the next question is where it should be fixed?

libgpiod silently weren't getting directory inside /proc/irq/${irq}
and nobody noticed until now.

I think returning error may be too harsh but replacing characters is not.

> Sorry, i took my original message because posting the last message to
> linux-fsdevel without context would be pointless.