[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240225231647.3abdf378@aktux>
Date: Sun, 25 Feb 2024 23:16:47 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
johan@...nel.org, jirislaby@...nel.org, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org, Adam Ford
<aford173@...il.com>, Tony Lindgren <tony@...mide.com>,
tomi.valkeinen@...asonboard.com, Péter Ujfalusi
<peter.ujfalusi@...il.com>, robh@...nel.org, hns@...delico.com
Subject: Re: [RFC PATCH v2 3/3] gnss: Add driver for AI2 protocol
Hi Paul,
I have left out one thing to answer.
On Mon, 29 Jan 2024 08:53:27 +0100
Paul Menzel <pmenzel@...gen.mpg.de> wrote:
> > + ret = ai2_send_frame(ai2dev, skb);
> > + if (ret)
> > + return ret;
> > +
> > + msleep(200);
>
> I’d be great if you added a comment, why this long delay is needed.
Well, I am just a bit paranoid, s/msleep/wait_for_completion_timeout/ and
complete() on some ack would probably improve this. I just hesitated to add
something like this until I have the feeling that I do not need to turn the
driver upside-down.
Regards,
Andreas
Powered by blists - more mailing lists