linux-kernel - Re: [PATCH v8 23/38] input: keypad: ep93xx: add DT support for Cirrus EP93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdyjWVwYRfASc38I@smile.fi.intel.com>
Date: Mon, 26 Feb 2024 16:42:33 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: nikita.shubin@...uefel.me
Cc: Hartley Sweeten <hsweeten@...ionengravers.com>,
	Alexander Sverdlin <alexander.sverdlin@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Damien Le Moal <dlemoal@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v8 23/38] input: keypad: ep93xx: add DT support for
 Cirrus EP93xx

On Mon, Feb 26, 2024 at 10:30:19AM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@...uefel.me>
> 
> - drop flags, they were not used anyway
> - add OF ID match table
> - process "autorepeat", "debounce-delay-ms", prescale from device tree
> - drop platform data usage and it's header
> - keymap goes from device tree now on

..

>  struct ep93xx_keypad {
> -	struct ep93xx_keypad_platform_data *pdata;
>  	struct input_dev *input_dev;
>  	struct clk *clk;
> +	unsigned int	debounce;
> +	uint16_t	prescale;

In case you need to send a new version note that the indentation of the fields
is different here. Also uint16_t is not the type we expect to see usually
(does the file use it already?). In kernel we have u16.

>  	void __iomem *mmio_base;

-- 
With Best Regards,
Andy Shevchenko