linux-kernel - Re: [PATCH 1/4] staging: pi433: Remove a duplicated F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdykDGo9fMw5fEdp@smile.fi.intel.com>
Date: Mon, 26 Feb 2024 16:45:32 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shahar Avidar <ikobh7@...il.com>
Cc: gregkh@...uxfoundation.org, luca.ceresoli@...tlin.com,
	benjamin.tissoires@...hat.com, elder@...aro.org, robh@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: pi433: Remove a duplicated F_OSC define

On Sun, Feb 25, 2024 at 07:33:38PM +0200, Shahar Avidar wrote:
> F_OSC is already defined & only used by rf69.c source file
> Also fix define comment

You missed periods at the end of the sentences.

..

> -#define F_OSC	  32000000 /* in Hz */
> +#define F_OSC	  32000000 /* Hz */

Instead of having a comment you can

  #include <linux/units.h>
  ...
  #define F_OSC	  (32 * HZ_PER_MHZ)

which will be more robust code (no need to count 0s).

-- 
With Best Regards,
Andy Shevchenko