linux-kernel - Re: [PATCH] ext4: remove unused parameter biop in ext4_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <875xyb1c3v.fsf@doe.com>
Date: Mon, 26 Feb 2024 20:55:40 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Wenchao Hao <haowenchao2@...wei.com>, Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: louhongxiang@...wei.com, Wenchao Hao <haowenchao2@...wei.com>
Subject: Re: [PATCH] ext4: remove unused parameter biop in ext4_issue_discard()

Wenchao Hao <haowenchao2@...wei.com> writes:

> all caller of ext4_issue_discard() would set biop to NULL since
> 'commit 55cdd0af2bc5 ("ext4: get discard out of jbd2 commit kthread
> contex")', it's unnecessary to keep this parameter any more.
>
> Signed-off-by: Wenchao Hao <haowenchao2@...wei.com>

Nice little cleanup. Feel free to add - 

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>