linux-kernel - Re: [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 16:52:26 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Shengyu Qu <wiagn233@...look.com>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, hkallweit1@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2

On Mon, Feb 26, 2024 at 11:42:49PM +0800, Shengyu Qu wrote:
> Hi Andrew,
> 
> So I should describe in commit message that user should set the stick to
> 2.5g/automatic mode and include the link in previous mail? Is that enough?

As Russell pointed out, this sounds racy. We need lots of details in
the commit message to convince us this is safe, and is not going to
cause a regression. If it does break and cause a regression, having
those details will also help us decide what to do, other than just
revert the change.

The further the devices get from well defined standardised behaviour,
the more details are needed.

       Andrew