[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240226-germinate-anymore-fb85ca9bb226@spud>
Date: Mon, 26 Feb 2024 16:24:47 +0000
From: Conor Dooley <conor@...nel.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: haibo.chen@....com, jic23@...nel.org, lars@...afoo.de, robh@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
>
> Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> so drop it.
Don't just remove it from the example, drop it from the binding too?
It does permit a 4th "self testing" interrupt.
Thanks,
Conor.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..dfc3f512918f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -31,7 +31,6 @@ properties:
> - description: normal conversion, include EOC (End of Conversion),
> ECH (End of Chain), JEOC (End of Injected Conversion) and
> JECH (End of injected Chain).
> - - description: Self-testing Interrupts.
>
> clocks:
> maxItems: 1
> @@ -70,8 +69,7 @@ examples:
> reg = <0x44530000 0x10000>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> + <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX93_CLK_ADC1_GATE>;
> clock-names = "ipg";
> vref-supply = <®_vref_1v8>;
> --
> 2.37.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists