linux-kernel - Re: [PATCH 01/20] Staging: rtl8192e: Rename function rtllib_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 17:59:15 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Tree Davies <tdavies@...kphysics.net>, gregkh@...uxfoundation.org,
 anjan@...i.ca
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/20] Staging: rtl8192e: Rename function
 rtllib_rx_ADDBAReq()

On 2/26/24 04:56, Tree Davies wrote:
> Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch
> warning Avoid CamelCase.
> 
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#7:
Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch
> Signed-off-by: Tree Davies <tdavies@...kphysics.net>
> ---
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
>   drivers/staging/rtl8192e/rtllib.h         | 2 +-
>   drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index da7319c124e7..bd1d86e0323d 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -211,7 +211,7 @@ static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst,
>   		netdev_dbg(ieee->dev, "Failed to generate DELBA packet.\n");
>   }
>   
> -int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> +int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb)
>   {
>   	struct ieee80211_hdr_3addr *req = NULL;
>   	u16 rc = 0;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 348644998744..95a8e9416f61 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1771,7 +1771,7 @@ u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame);
>   void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
>   bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
>   u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> -int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
> +int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
>   int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
>   int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
>   void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts,
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 2545ac8963c4..f12ee685e989 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1551,7 +1551,7 @@ static void rtllib_process_action(struct rtllib_device *ieee,
>   	case ACT_CAT_BA:
>   		switch (*act) {
>   		case ACT_ADDBAREQ:
> -			rtllib_rx_ADDBAReq(ieee, skb);
> +			rtllib_rx_add_ba_req(ieee, skb);
>   			break;
>   		case ACT_ADDBARSP:
>   			rtllib_rx_add_ba_rsp(ieee, skb);