linux-kernel - Re: [PATCH 7/8] Staging: rtl8192e: Rename function rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <535eb04e-19bb-4d64-9818-7fc28195b9b1@gmail.com>
Date: Mon, 26 Feb 2024 17:57:24 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Tree Davies <tdavies@...kphysics.net>, gregkh@...uxfoundation.org,
 anjan@...i.ca
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] Staging: rtl8192e: Rename function
 rtllib_FlushRxTsPendingPkts()

On 2/26/24 04:59, Tree Davies wrote:
> Rename function rtllib_FlushRxTsPendingPkts -> rtllib_flush_rx_ts_pending_pkts
This line is too long.
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#
> to fix checkpatch warning Avoid CamelCase.
> 
> Signed-off-by: Tree Davies <tdavies@...kphysics.net>
> ---
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
>   drivers/staging/rtl8192e/rtllib.h         | 2 +-
>   drivers/staging/rtl8192e/rtllib_rx.c      | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 0581ed1e9ed1..04f3fb54d1b7 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -268,7 +268,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb)
>   		goto on_add_ba_req_fail;
>   	}
>   
> -	rtllib_FlushRxTsPendingPkts(ieee, ts);
> +	rtllib_flush_rx_ts_pending_pkts(ieee, ts);
>   
>   	deactivate_ba_entry(ieee, ba);
>   	ba->dialog_token = *dialog_token;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 05abc001507c..fe850dbeaa02 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1810,7 +1810,7 @@ bool rtllib_mgnt_disconnect(struct rtllib_device *rtllib, u8 rsn);
>   /* For the function is more related to hardware setting, it's better to use the
>    * ieee handler to refer to it.
>    */
> -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
> +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee,
>   				 struct rx_ts_record *ts);
CHECK: Alignment should match open parenthesis
#40: FILE: drivers/staging/rtl8192e/rtllib.h:1814:
+void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee,
  				 struct rx_ts_record *ts);


>   int rtllib_parse_info_param(struct rtllib_device *ieee,
>   			    struct rtllib_info_element *info_element,
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 051371e0138c..be0f92e97d12 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -487,7 +487,7 @@ void rtllib_indicate_packets(struct rtllib_device *ieee,
>   	}
>   }
>   
> -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
> +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee,
>   				 struct rx_ts_record *ts)
CHECK: Alignment should match open parenthesis
#40: FILE: drivers/staging/rtl8192e/rtllib.h:1814:
+void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee,
  				 struct rx_ts_record *ts);


>   {
>   	struct rx_reorder_entry *pRxReorderEntry;