linux-kernel - Re: [PATCH v18 002/121] x86/virt/tdx: Export SEAMCALL functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240226175107.GB177224@ls.amr.corp.intel.com>
Date: Mon, 26 Feb 2024 09:51:07 -0800
From: Isaku Yamahata <isaku.yamahata@...ux.intel.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: isaku.yamahata@...el.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, isaku.yamahata@...il.com,
	erdemaktas@...gle.com, Sean Christopherson <seanjc@...gle.com>,
	Sagi Shahar <sagis@...gle.com>, Kai Huang <kai.huang@...el.com>,
	chen.bo@...el.com, hang.yuan@...el.com, tina.zhang@...el.com,
	isaku.yamahata@...ux.intel.com
Subject: Re: [PATCH v18 002/121] x86/virt/tdx: Export SEAMCALL functions

On Thu, Feb 08, 2024 at 02:30:40PM +0100,
Paolo Bonzini <pbonzini@...hat.com> wrote:

> On Tue, Jan 23, 2024 at 12:54 AM <isaku.yamahata@...el.com> wrote:
> >
> > From: Kai Huang <kai.huang@...el.com>
> >
> > KVM will need to make SEAMCALLs to create and run TDX guests.  Export
> > SEAMCALL functions for KVM to use.
> >
> > Also add declaration of SEAMCALL functions to <asm/asm-prototypes.h> to
> > support CONFIG_MODVERSIONS=y.
> >
> > Signed-off-by: Kai Huang <kai.huang@...el.com>
> 
> I thought you were going to introduce builtin functions for SEAMCALLs
> needed by KVM, instead?

After I talked with Kai, I concluded to use the common function.
Probably for TDH.VP.ENTER, we'd like to use customized version to avoid
shuffling registers between struct tdx_module_args and KVM regs.  We can do it
later as optimization.
-- 
Isaku Yamahata <isaku.yamahata@...ux.intel.com>