[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <80bc4de5-a351-4ac0-93c8-80c8d80fb202@csgroup.eu>
Date: Mon, 26 Feb 2024 18:53:57 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Arnd Bergmann <arnd@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
Vincenzo Frascino <vincenzo.frascino@....com>, Kees Cook
<keescook@...omium.org>, Anna-Maria Behnsen <anna-maria@...utronix.de>
CC: Arnd Bergmann <arnd@...db.de>, Matt Turner <mattst88@...il.com>, Vineet
Gupta <vgupta@...nel.org>, Russell King <linux@...linux.org.uk>, Catalin
Marinas <catalin.marinas@....com>, Guo Ren <guoren@...nel.org>, Brian Cain
<bcain@...cinc.com>, Huacai Chen <chenhuacai@...nel.org>, Geert Uytterhoeven
<geert@...ux-m68k.org>, Michal Simek <monstr@...str.eu>, Thomas Bogendoerfer
<tsbogend@...ha.franken.de>, Helge Deller <deller@....de>, Michael Ellerman
<mpe@...erman.id.au>, Palmer Dabbelt <palmer@...belt.com>, John Paul Adrian
Glaubitz <glaubitz@...sik.fu-berlin.de>, Andreas Larsson
<andreas@...sler.com>, Richard Weinberger <richard@....at>, "x86@...nel.org"
<x86@...nel.org>, Max Filippov <jcmvbkbc@...il.com>, Andy Lutomirski
<luto@...nel.org>, Jan Kiszka <jan.kiszka@...mens.com>, Kieran Bingham
<kbingham@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
"linux-snps-arc@...ts.infradead.org" <linux-snps-arc@...ts.infradead.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-csky@...r.kernel.org"
<linux-csky@...r.kernel.org>, "linux-hexagon@...r.kernel.org"
<linux-hexagon@...r.kernel.org>, "loongarch@...ts.linux.dev"
<loongarch@...ts.linux.dev>, "linux-m68k@...ts.linux-m68k.org"
<linux-m68k@...ts.linux-m68k.org>, "linux-mips@...r.kernel.org"
<linux-mips@...r.kernel.org>, "linux-openrisc@...r.kernel.org"
<linux-openrisc@...r.kernel.org>, "linux-parisc@...r.kernel.org"
<linux-parisc@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org"
<linuxppc-dev@...ts.ozlabs.org>, "linux-riscv@...ts.infradead.org"
<linux-riscv@...ts.infradead.org>, "linux-s390@...r.kernel.org"
<linux-s390@...r.kernel.org>, "linux-sh@...r.kernel.org"
<linux-sh@...r.kernel.org>, "sparclinux@...r.kernel.org"
<sparclinux@...r.kernel.org>, "linux-um@...ts.infradead.org"
<linux-um@...ts.infradead.org>, Linux Kernel Functional Testing
<lkft@...aro.org>
Subject: Re: [PATCH 4/4] vdso: avoid including asm/page.h
Le 26/02/2024 à 17:14, Arnd Bergmann a écrit :
> From: Arnd Bergmann <arnd@...db.de>
>
> The recent change to the vdso_data_store broke building compat VDSO
> on at least arm64 because it includes headers outside of the include/vdso/
> namespace:
I understand that powerpc64 also has an issue, see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20231221120410.2226678-1-mpe@ellerman.id.au/
>
> In file included from arch/arm64/include/asm/lse.h:5,
> from arch/arm64/include/asm/cmpxchg.h:14,
> from arch/arm64/include/asm/atomic.h:16,
> from include/linux/atomic.h:7,
> from include/asm-generic/bitops/atomic.h:5,
> from arch/arm64/include/asm/bitops.h:25,
> from include/linux/bitops.h:68,
> from arch/arm64/include/asm/memory.h:209,
> from arch/arm64/include/asm/page.h:46,
> from include/vdso/datapage.h:22,
> from lib/vdso/gettimeofday.c:5,
> from <command-line>:
> arch/arm64/include/asm/atomic_ll_sc.h:298:9: error: unknown type name 'u128'
> 298 | u128 full;
>
> Use an open-coded page size calculation based on the new CONFIG_PAGE_SHIFT
> Kconfig symbol instead.
>
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Fixes: a0d2fcd62ac2 ("vdso/ARM: Make union vdso_data_store available for all architectures")
> Link: https://lore.kernel.org/lkml/CA+G9fYtrXXm_KO9fNPz3XaRxHV7UD_yQp-TEuPQrNRHU+_0W_Q@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> include/vdso/datapage.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
> index 7ba44379a095..2c39a67d7e23 100644
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -19,8 +19,6 @@
> #include <vdso/time32.h>
> #include <vdso/time64.h>
>
> -#include <asm/page.h>
> -
> #ifdef CONFIG_ARCH_HAS_VDSO_DATA
> #include <asm/vdso/data.h>
> #else
> @@ -128,7 +126,7 @@ extern struct vdso_data _timens_data[CS_BASES] __attribute__((visibility("hidden
> */
> union vdso_data_store {
> struct vdso_data data[CS_BASES];
> - u8 page[PAGE_SIZE];
> + u8 page[1ul << CONFIG_PAGE_SHIFT];
Usually 1UL is used (capital letter)
Maybe better to (re)define PAGE_SIZE instead, something like:
#define PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT)
> };
>
> /*
Powered by blists - more mailing lists