linux-kernel - Re: [PATCH v19 028/130] KVM: TDX: Add TDX "architectural" error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240226192757.GS177224@ls.amr.corp.intel.com>
Date: Mon, 26 Feb 2024 11:27:57 -0800
From: Isaku Yamahata <isaku.yamahata@...ux.intel.com>
To: isaku.yamahata@...el.com
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	isaku.yamahata@...il.com, Paolo Bonzini <pbonzini@...hat.com>,
	erdemaktas@...gle.com, Sean Christopherson <seanjc@...gle.com>,
	Sagi Shahar <sagis@...gle.com>, Kai Huang <kai.huang@...el.com>,
	chen.bo@...el.com, hang.yuan@...el.com, tina.zhang@...el.com,
	Sean Christopherson <sean.j.christopherson@...el.com>,
	Yuan Yao <yuan.yao@...el.com>, Xiaoyao Li <xiaoyao.li@...el.com>,
	isaku.yamahata@...ux.intel.com
Subject: Re: [PATCH v19 028/130] KVM: TDX: Add TDX "architectural" error codes

On Mon, Feb 26, 2024 at 12:25:30AM -0800,
isaku.yamahata@...el.com wrote:

> diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
> index fdfd41511b02..28c4a62b7dba 100644
> --- a/arch/x86/include/asm/shared/tdx.h
> +++ b/arch/x86/include/asm/shared/tdx.h
> @@ -26,7 +26,13 @@
>  #define TDVMCALL_GET_QUOTE		0x10002
>  #define TDVMCALL_REPORT_FATAL_ERROR	0x10003
>  
> -#define TDVMCALL_STATUS_RETRY		1

Oops, I accidentally removed this constant to break tdx guest build.

diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
index ef1c8e5a2944..1367a5941499 100644
--- a/arch/x86/include/asm/shared/tdx.h
+++ b/arch/x86/include/asm/shared/tdx.h
@@ -28,6 +28,8 @@
 #define TDVMCALL_REPORT_FATAL_ERROR    0x10003
 #define TDVMCALL_SETUP_EVENT_NOTIFY_INTERRUPT  0x10004
 
+#define TDVMCALL_STATUS_RETRY          1
+
 /*
  * TDG.VP.VMCALL Status Codes (returned in R10)
  */
-- 
2.25.1
-- 
Isaku Yamahata <isaku.yamahata@...ux.intel.com>