linux-kernel - Re: [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 21:50:55 +0100
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Bo Liu <liubo03@...pur.com>, alex.aring@...il.com,
 miquel.raynal@...tlin.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Cc: linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ieee802154: mrf24j40: convert to use maple tree
 register cache

Hello,

On 02.02.24 07:46, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>   drivers/net/ieee802154/mrf24j40.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee4cfbf2c5cc..d3f42efc5d1a 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -388,7 +388,7 @@ static const struct regmap_config mrf24j40_short_regmap = {
>   	.pad_bits = 1,
>   	.write_flag_mask = MRF24J40_SHORT_WRITE,
>   	.read_flag_mask = MRF24J40_SHORT_READ,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.max_register = MRF24J40_SHORT_NUMREGS,
>   	.writeable_reg = mrf24j40_short_reg_writeable,
>   	.readable_reg = mrf24j40_short_reg_readable,
> @@ -495,7 +495,7 @@ static const struct regmap_config mrf24j40_long_regmap = {
>   	.pad_bits = 5,
>   	.write_flag_mask = MRF24J40_LONG_ACCESS,
>   	.read_flag_mask = MRF24J40_LONG_ACCESS,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.max_register = MRF24J40_LONG_NUMREGS,
>   	.writeable_reg = mrf24j40_long_reg_writeable,
>   	.readable_reg = mrf24j40_long_reg_readable,

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt