linux-kernel - Re: [PATCH] psi: Fix avg trigger being fired unexpectedly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM7-yPRZ1vXAY1_=kdNrgmL7i206O_s6z0_92KwzM0ENED=pCA@mail.gmail.com>
Date: Mon, 26 Feb 2024 21:07:51 +0000
From: Yun Levi <ppbuk5246@...il.com>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: hannes@...xchg.org, peterz@...radead.org, mingo@...hat.com, 
	juri.lelli@...hat.com, vincent.guittot@...aro.org, dietmar.eggemann@....com, 
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, 
	vschneid@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] psi: Fix avg trigger being fired unexpectedly.

Hi Suren.

> s/accumlated/accumulated
>
> > But, for PSI_AVGS, win->value should be initialized with group->total[PSI_AVGS].
> > Moreover, to get exact initial value for win->value, it should be set
> > under each trigger lock to synchronize each rtpoll/avgs_works.
>
> That last "to synchronize each rtpoll/avgs_works." part I would
> replace with "to avoid concurrent changes to group->total[]."
>
> Other than these nits LGTM. After fixing them feel free to add:
>
> Acked-by: Suren Baghdasaryan <surenb@...gle.com>

Thanks. I'll fix my commit message ;)