linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240226220637.7bc64b95@jic23-huawei>
Date: Mon, 26 Feb 2024 22:06:37 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: "Peng Fan (OSS)" <peng.fan@....nxp.com>, haibo.chen@....com,
 lars@...afoo.de, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Peng
 Fan <peng.fan@....com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th
 interrupt

On Mon, 26 Feb 2024 21:17:06 +0000
Conor Dooley <conor@...nel.org> wrote:

> On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> > On Mon, 26 Feb 2024 16:24:47 +0000
> > Conor Dooley <conor@...nel.org> wrote:
> >   
> > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:  
> > > > From: Peng Fan <peng.fan@....com>
> > > > 
> > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > > so drop it.    
> > > 
> > > Don't just remove it from the example, drop it from the binding too?
> > > It does permit a 4th "self testing" interrupt.  
> > 
> > I'm missing something. See below...  
> > > 
> > > Thanks,
> > > Conor.
> > >   
> > > > 
> > > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > index dacc526dc695..dfc3f512918f 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > @@ -31,7 +31,6 @@ properties:
> > > >        - description: normal conversion, include EOC (End of Conversion),
> > > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > >            JECH (End of injected Chain).
> > > > -      - description: Self-testing Interrupts.  
> > 
> > Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...  
> 
> Huh, wonder how I missed that. I thought I double checked...
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Cheers,
> Conor.

Happens to us all!  Applied patch 1 to the togreg branch of iio.git and pushed
it out as testing so 0-day can poke at it.
Thanks,

Jonathan