linux-kernel - Re: [PATCH] ocfs2: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d34ba82f-cde8-4bf9-ab97-a1c4c06c2972@linux.alibaba.com>
Date: Mon, 26 Feb 2024 09:11:09 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Chengming Zhou <chengming.zhou@...ux.dev>, mark@...heh.com,
 jlbec@...lplan.org, brauner@...nel.org, jlayton@...nel.org,
 keescook@...omium.org, akpm <akpm@...ux-foundation.org>
Cc: jack@...e.cz, zhouchengming@...edance.com, azeemshaikh38@...il.com,
 ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, vbabka@...e.cz, roman.gushchin@...ux.dev,
 Xiongwei.Song@...driver.com
Subject: Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage



On 2/25/24 9:02 PM, Chengming Zhou wrote:
> On 2024/2/25 20:20, Joseph Qi wrote:
>>
>>
>> On 2/24/24 9:50 PM, chengming.zhou@...ux.dev wrote:
>>> From: Chengming Zhou <zhouchengming@...edance.com>
>>>
>>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>>> its usage so we can delete it from slab. No functional change.
>>>
>> If I understand correctly, you are referring the following patch:
>> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>>
>> But it seems that the above patch is not included in mainline yet.
>> Or am I missing something?
> 
> I realize my commit message should explain more why it's a no-op, my bad.
> 
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed so it became a dead flag as of v6.8-rc1. That series[1]
> mark it obsolete to avoid confusion for users. So here we can just
> remove all its users, which has no functional changes.
> 
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
> 
Take more look at v6.8-rc1, I've found the following commit:
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
It seems that after this commit, there is no user of 'SLAB_MEM_SPREAD'. So,
Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com>