[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <w75crq6ofqq6gisxdda6zeyem5gmsrexe7zarrza46awpstlvk@lc7bttbt63el>
Date: Tue, 27 Feb 2024 00:57:08 +0100
From: Ondřej Jirman <megi@....cz>
To: Rob Herring <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
Conor Dooley <conor+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
Arnaud Ferraris <arnaud.ferraris@...labora.com>, linux-sound@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [RESEND PATCH v2 1/5] dt-bindings: sound: Add jack-type property
to sun8i-a33-codec
On Mon, Feb 26, 2024 at 01:47:27PM -0600, Rob Herring wrote:
> On Sat, Feb 24, 2024 at 02:54:54PM +0100, Ondřej Jirman wrote:
> > From: Ondrej Jirman <megi@....cz>
> >
> > The codec driver needs to know what jack connector it is connected to
> > on the board. Add proprty to describe the type of connector.
> >
> > Signed-off-by: Ondrej Jirman <megi@....cz>
> > ---
> > .../bindings/sound/allwinner,sun8i-a33-codec.yaml | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
> > index 63eadc4200ac..399fc00ad3f4 100644
> > --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
> > +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
> > @@ -44,6 +44,15 @@ properties:
> > - const: bus
> > - const: mod
> >
> > + jack-type:
>
> I'm all for a generic property name, but it needs to be documented
> somewhere common. Perhaps dai-common.yaml.
>
> I'm sure there is some prior art here to consider as well.
There's only a mention in the code. But there's no use of similar property
on the codec nodes.
https://elixir.bootlin.com/linux/latest/source/sound/soc/soc-component.c#L288
/**
* snd_soc_component_get_jack_type
* @component: COMPONENTs
*
* Returns the jack type of the component
* This can either be the supported type or one read from
* devicetree with the property: jack-type.
*/
This is part of a component, so maybe in sound/component-common.yaml ?
Kind regards,
o.
> Rob
Powered by blists - more mailing lists