linux-kernel - RE: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f281e9b6073143e7912f5d9ddb6ee217@realtek.com>
Date: Mon, 26 Feb 2024 01:18:05 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Shiji Yang <yangshiji66@...look.com>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>
CC: Jes Sorensen <Jes.Sorensen@...il.com>, Kalle Valo <kvalo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs()



> -----Original Message-----
> From: Shiji Yang <yangshiji66@...look.com>
> Sent: Friday, February 23, 2024 9:35 PM
> To: linux-wireless@...r.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@...il.com>; Kalle Valo <kvalo@...nel.org>; linux-kernel@...r.kernel.org;
> Shiji Yang <yangshiji66@...look.com>
> Subject: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs()
> 
> Moving struct ieee80211_sta *sta variable definition to the front
> of the code to fix the ISO C90 forbids mixed declarations and code
> warning.

I suppose there will be no this kind of warnings after
the commit b5ec6fd286df ("kbuild: Drop -Wdeclaration-after-statement") since
v6.5. But as commit message mentioned -- 
" It will still be recommeneded to place declarations at the start of a
  scope where possible, but it will no longer be enforced."
Then, this patch looks good to me. 

> 
> Fixes: 43532c050f8e ("wifi: rtl8xxxu: support multiple interfaces in set_aifs()")
> Signed-off-by: Shiji Yang <yangshiji66@...look.com>

Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>