linux-kernel - Re: [PATCH v3 3/4] usb: typec: tcpm: add support to set tcpc connector orientatition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 10:03:30 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: gregkh@...uxfoundation.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	linux@...ck-us.net, jun.li@....com, devicetree@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v3 3/4] usb: typec: tcpm: add support to set tcpc
 connector orientatition

On Thu, Feb 22, 2024 at 10:09:02PM +0100, Marco Felsch wrote:
> This adds the support to set the connector orientation value
> accordingly. This is part of the optional CONFIG_STANDARD_OUTPUT
> register 0x18, specified within the USB port controller spsicification
> rev. 2.0 [1].
> 
> [1] https://www.usb.org/sites/default/files/documents/usb-port_controller_specification_rev2.0_v1.0_0.pdf
> 
> Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
> v3:
> - no changes
> v2:
> - no changes
> 
>  drivers/usb/typec/tcpm/tcpm.c | 6 ++++++
>  include/linux/usb/tcpm.h      | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 5945e3a2b0f7..85ca26687324 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1099,6 +1099,12 @@ static int tcpm_set_roles(struct tcpm_port *port, bool attached,
>  	if (ret < 0)
>  		return ret;
>  
> +	if (port->tcpc->set_orientation) {
> +		ret = port->tcpc->set_orientation(port->tcpc, orientation);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
>  	port->pwr_role = role;
>  	port->data_role = data;
>  	typec_set_data_role(port->typec_port, data);
> diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h
> index 65fac5e1f317..93b681ff3ef9 100644
> --- a/include/linux/usb/tcpm.h
> +++ b/include/linux/usb/tcpm.h
> @@ -133,6 +133,8 @@ struct tcpc_dev {
>  		      enum typec_cc_status *cc2);
>  	int (*set_polarity)(struct tcpc_dev *dev,
>  			    enum typec_cc_polarity polarity);
> +	int (*set_orientation)(struct tcpc_dev *dev,
> +			       enum typec_orientation orientation);
>  	int (*set_vconn)(struct tcpc_dev *dev, bool on);
>  	int (*set_vbus)(struct tcpc_dev *dev, bool on, bool charge);
>  	int (*set_current_limit)(struct tcpc_dev *dev, u32 max_ma, u32 mv);
> -- 
> 2.39.2

-- 
heikki