linux-kernel - Re: [PATCH] dt-bindings: serial: convert st,asc to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 09:09:03 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Raphaël Gallais-Pou <rgallaispou@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Patrice Chotard <patrice.chotard@...s.st.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: convert st,asc to DT schema

On 26/02/2024 08:38, Raphaël Gallais-Pou wrote:
>>> +
>>> +allOf:
>>> +  - $ref: serial.yaml#
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: st,asc
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>
>> This wasn't here before and your commit msg does not explain it.
> 
> Looking at the device-tree I found that every instance of this device 
> refers to a phandle of a clock.
> 
> Moreover in the driver of the device, the probe fails if it does not 
> find a clock, hence this addition.
> 
> cf. drivers/tty/serial/st-asc.c:701

Commit msg should explain differences from pure conversion and the
reason behind. Otherwise how can we know why you did it?


Best regards,
Krzysztof