[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZdxPg0+DHX7/zede@kuha.fi.intel.com>
Date: Mon, 26 Feb 2024 10:44:51 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: fix UCSI on SM8550 & SM8650 Qualcomm
devices
On Fri, Feb 23, 2024 at 10:40:40AM +0100, Neil Armstrong wrote:
> On SM8550 and SM8650 Qualcomm platforms a call to UCSI_GET_PDOS for
> non-PD partners will cause a firmware crash with no
> easy way to recover from it.
>
> Add UCSI_NO_PARTNER_PDOS quirk for those platform until we find
> a way to properly handle the crash.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c
> index 0bd3f6dee678..932e7bf69447 100644
> --- a/drivers/usb/typec/ucsi/ucsi_glink.c
> +++ b/drivers/usb/typec/ucsi/ucsi_glink.c
> @@ -302,6 +302,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = {
> { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> { .compatible = "qcom,sm8350-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> + { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> {}
> };
>
>
> ---
> base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
> change-id: 20240223-topic-sm8550-upstream-ucsi-no-pdos-62fdad669f90
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@...aro.org>
--
heikki
Powered by blists - more mailing lists