linux-kernel - Re: [PATCH] clk: clocking-wizard: Remove redundant initialization of pointer div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe89c82c-18e8-4acf-97c7-a319f20c26f4@amd.com>
Date: Mon, 26 Feb 2024 09:45:11 +0100
From: Michal Simek <michal.simek@....com>
To: Colin Ian King <colin.i.king@...il.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: clocking-wizard: Remove redundant initialization of
 pointer div_addr



On 2/23/24 14:43, Colin Ian King wrote:
> The pointer div_addr is being assigned a value that is never used, it is
> being re-assigned a different value near the end of the function where
> it is being read in the next statement. The initialization is redundant
> and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/clk/xilinx/clk-xlnx-clock-wizard.c:501:16: warning: Value stored
> to 'div_addr' during its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> index 6a6e5d9292e8..19eb3fb7ae31 100644
> --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> @@ -498,7 +498,7 @@ static int clk_wzrd_dynamic_all_nolock(struct clk_hw *hw, unsigned long rate,
>   {
>   	struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
>   	unsigned long vco_freq, rate_div, clockout0_div;
> -	void __iomem *div_addr = divider->base;
> +	void __iomem *div_addr;
>   	u32 reg, pre, f;
>   	int err;
>   

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal