linux-kernel - Re: [PATCH] [RFQ] dm-integrity: Add a lazy commit mode for journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48f94af1-3969-4021-84f7-5822bd92b38e@gmail.com>
Date: Mon, 26 Feb 2024 09:48:05 +0100
From: Milan Broz <gmazyland@...il.com>
To: Weiß, Simone <Simone.Weiss@...ktrobit.com>,
 "mpatocka@...hat.com" <mpatocka@...hat.com>
Cc: "song@...nel.org" <song@...nel.org>,
 "Tomerius, Kai" <Kai.Tomerius@...ktrobit.com>,
 "simone.p.weiss@...teo.net" <simone.p.weiss@...teo.net>,
 "agk@...hat.com" <agk@...hat.com>,
 "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
 "dm-devel@...ts.linux.dev" <dm-devel@...ts.linux.dev>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "yukuai3@...wei.com" <yukuai3@...wei.com>,
 "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
 "snitzer@...nel.org" <snitzer@...nel.org>
Subject: Re: [PATCH] [RFQ] dm-integrity: Add a lazy commit mode for journal

On 2/26/24 7:47 AM, Weiß, Simone wrote:
..
> I can do it this way for sure as well. Another point still in my mind is the
> superblock: I would like to get rid of the build time switch and carry
> information about lazy commits enabled in the superblock. As there is J, B, D
> and R as mode already, a new mode L or such could be added. I will work on this
> and also take a look at stuff like dmsetup to check if something would be needed
> there. If there are further points for now on anyone's mind, please tell.

Just FYI: I do not think you need to add anything to dmsetup, but integritysetup
(part of the cryptsetup project) needs to understand new metadata and dm-integrity
table options.

And I guess it needs to add a new option to use the new mode.

Perhaps it is best to create an issue for cryptsetup to discuss it, but it will not
be merged until the kernel code is on the way to mainline.

Milan