linux-kernel - Re: [PATCH v2 9/9] ARM: dts: chameleonv3: Add video device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <310cefcb-a4d5-4f4f-a482-ba2ff08a57f6@linaro.org>
Date: Mon, 26 Feb 2024 10:15:14 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Paweł Anikiel <panikiel@...gle.com>, airlied@...il.com,
 akpm@...ux-foundation.org, conor+dt@...nel.org, daniel@...ll.ch,
 dinguyen@...nel.org, hverkuil-cisco@...all.nl,
 krzysztof.kozlowski+dt@...aro.org, maarten.lankhorst@...ux.intel.com,
 mchehab@...nel.org, mripard@...nel.org, robh+dt@...nel.org,
 tzimmermann@...e.de
Cc: devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 chromeos-krk-upstreaming@...gle.com, ribalda@...omium.org
Subject: Re: [PATCH v2 9/9] ARM: dts: chameleonv3: Add video device nodes

On 21/02/2024 17:02, Paweł Anikiel wrote:
> Add device nodes for the video system present on the Chameleon v3.
> It consists of six framebuffers and two Intel Displayport receivers.
> 
> Signed-off-by: Paweł Anikiel <panikiel@...gle.com>
> ---

..

> +		dprx_sst: dp-receiver@...64000 {
> +			compatible = "intel,dprx-20.0.1";
> +			reg = <0xc0064000 0x800>;
> +			interrupt-parent = <&dprx_sst_irq>;
> +			interrupts = <0 IRQ_TYPE_EDGE_RISING>;
> +			intel,max-link-rate = <0x1e>;

Rate is not in hex! Rate is in Hz, at least usually...

Fix your bindings...

Best regards,
Krzysztof