linux-kernel - Re: [PATCH] ubifs: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85628515-9b75-4498-8a7f-1f1a33cfeca1@linux.dev>
Date: Mon, 26 Feb 2024 10:46:01 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Richard Weinberger <richard@....at>
Cc: linux-mtd <linux-mtd@...ts.infradead.org>,
 linux-kernel <linux-kernel@...r.kernel.org>, vbabka@...e.cz,
 roman gushchin <roman.gushchin@...ux.dev>,
 Xiongwei Song <Xiongwei.Song@...driver.com>
Subject: Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

On 2024/2/26 04:36, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "chengming zhou" <chengming.zhou@...ux.dev>
>> An: "richard" <richard@....at>
>> CC: "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "linux-mm"
>> <linux-mm@...ck.org>, vbabka@...e.cz, "roman gushchin" <roman.gushchin@...ux.dev>, "Xiongwei Song"
>> <Xiongwei.Song@...driver.com>, "chengming zhou" <chengming.zhou@...ux.dev>, "Chengming Zhou"
>> <zhouchengming@...edance.com>
>> Gesendet: Samstag, 24. Februar 2024 14:52:17
>> Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
> 
>> From: Chengming Zhou <zhouchengming@...edance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> 
> Applied.
> Next time please add a reference that makes very clear why such a flag
> is no longer needed.
> It took me a few minutes to figure why SLAB_MEM_SPREAD is
> now a no-op.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag. And the series[1]
went on to mark it obsolete to avoid confusion for users. Here we
can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

> 
> Thanks,
> //richard