linux-kernel - Re: [PATCH] powerpc/mm: Code cleanup for __hash_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6hva4b0.fsf@mail.lhotse>
Date: Mon, 26 Feb 2024 21:49:23 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Kunwu Chan <chentao@...inos.cn>, npiggin@...il.com,
 christophe.leroy@...roup.eu, aneesh.kumar@...nel.org,
 naveen.n.rao@...ux.ibm.com
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Kunwu Chan
 <chentao@...inos.cn>
Subject: Re: [PATCH] powerpc/mm: Code cleanup for __hash_page_thp

Kunwu Chan <chentao@...inos.cn> writes:
> This part was commented from commit 6d492ecc6489
> ("powerpc/THP: Add code to handle HPTE faults for hugepages")
> in about 11 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.

I agree the code can go. But I'd like it to be replaced with a comment
explaining what the dead code was trying to say.

cheers

> diff --git a/arch/powerpc/mm/book3s64/hash_hugepage.c b/arch/powerpc/mm/book3s64/hash_hugepage.c
> index c0fabe6c5a12..127a3a2c174b 100644
> --- a/arch/powerpc/mm/book3s64/hash_hugepage.c
> +++ b/arch/powerpc/mm/book3s64/hash_hugepage.c
> @@ -59,16 +59,6 @@ int __hash_page_thp(unsigned long ea, unsigned long access, unsigned long vsid,
>  
>  	rflags = htab_convert_pte_flags(new_pmd, flags);
>  
> -#if 0
> -	if (!cpu_has_feature(CPU_FTR_COHERENT_ICACHE)) {
> -
> -		/*
> -		 * No CPU has hugepages but lacks no execute, so we
> -		 * don't need to worry about that case
> -		 */
> -		rflags = hash_page_do_lazy_icache(rflags, __pte(old_pte), trap);
> -	}
> -#endif
>  	/*
>  	 * Find the slot index details for this ea, using base page size.
>  	 */
> -- 
> 2.39.2