linux-kernel - Re: [PATCH vRFC 3/8] treewide: rename firmware_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed9f2b75-38d3-8562-0476-2200e201d4c9@quicinc.com>
Date: Mon, 26 Feb 2024 16:22:09 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Greg KH <gregkh@...uxfoundation.org>, Luis Chamberlain <mcgrof@...nel.org>
CC: <russ.weight@...ux.dev>, <rafael@...nel.org>,
        <linux-kernel@...r.kernel.org>, <cocci@...teme.lip6.fr>
Subject: Re: [PATCH vRFC 3/8] treewide: rename firmware_request_platform()



On 2/24/2024 11:06 AM, Greg KH wrote:
> On Fri, Feb 23, 2024 at 11:42:35AM -0800, Luis Chamberlain wrote:
>> On Fri, Feb 23, 2024 at 04:33:40PM +0100, Greg KH wrote:
>>> On Fri, Feb 23, 2024 at 07:15:45AM -0800, Luis Chamberlain wrote:
>>>> On Fri, Feb 23, 2024 at 07:21:31AM +0100, Greg KH wrote:
>>>>> On Thu, Feb 22, 2024 at 11:30:28PM +0530, Mukesh Ojha wrote:
>>>>>> Rename firmware_request_platform() to request_firmware_platform()
>>>>>> to be more concrete and align with the name of other request
>>>>>> firmware family functions.
>>>>>
>>>>> Sorry, but no, it should be "noun_verb" for public functions.
>>>>
>>>> News to me, do we have this documented somewhere?
>>>
>>> Not really, but searching makes it nicer.
>>>
>>> And yes, I violated this in the past in places, and have regretted it...
>>
>> Care to share a few examples of regret?
> 
> 	get_device()
> 	put_device()
> 	kill_device()
> 
> vs. a saner:
> 	kobject_get()
> 	kobject_put()
> 	kobject_del()
> 
> Learn from the mistakes of my youth please :)

Thanks for the history.,
In that case, should we fix this verb_noun cases ?

request_firmware()
request_firmware_into_buf()
request_firmware_nowarn()
request_firmware_direct()
request_firmware_cache()
request_partial_firmware_into_buf()
release_firmware()

-Mukesh

> 
> thanks,
> 
> greg k-h