linux-kernel - Re: [PATCH v3] Staging: rtl8723bs: Remove spaces before tabs in rtw_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHdEp89HhwiBuQEqTP8nTTy0VPrLr5PKWi8mKLx6wFzeTb9eXw@mail.gmail.com>
Date: Mon, 26 Feb 2024 14:05:19 +0200
From: meir elisha <meir6264@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hans de Goede <hdegoede@...hat.com>, 
	Ruan Jinjie <ruanjinjie@...wei.com>, Yang Yingliang <yangyingliang@...wei.com>, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Staging: rtl8723bs: Remove spaces before tabs in rtw_set_auth

Hi Dan

Thanks for the response.
Not sure I got the problem here.
In V2 I removed spaces and deleted dead code. In V3 I just removed
spaces after tabs (reverting the dead code changes).
I'll want to create a seperate patch for the dead code deletion later on.
What am I missing here?

‫בתאריך יום ב׳, 26 בפבר׳ 2024 ב-12:23 מאת ‪Dan Carpenter‬‏
<‪dan.carpenter@...aro.org‬‏>:‬
>
> On Mon, Feb 26, 2024 at 09:52:25AM +0200, Meir Elisha wrote:
> > Remove spaces before tabs to improve coding style.
> >
> > Signed-off-by: Meir Elisha <meir6264@...il.com>
> > ---
> > Changes in v3: subject and description changed, revert dead code changes
> > Changes in v2: remove dead code
> >
>
> Sorry that I was not clear.  This needs to be split into two patches:
> [patch 1] delete dead code
> [patch 2] remove spaces before tabs
>
> regards,
> dan carpenter
>