linux-kernel - Re: [syzbot] [ntfs3?] possible deadlock in ntfs_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 20:06:23 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+c2ada45c23d98d646118@...kaller.appspotmail.com>
Cc: almaz.alexandrovich@...agon-software.com,
	boqun.feng@...il.com,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	ntfs3@...ts.linux.dev,
	penguin-kernel@...ove.sakura.ne.jp,
	syzkaller-bugs@...glegroups.com,
	torvalds@...ux-foundation.org
Subject: Re: [syzbot] [ntfs3?] possible deadlock in ntfs_set_state (2)

Test non-zero subkey against the mainline tree.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  master

--- x/fs/ntfs3/fsntfs.c
+++ y/fs/ntfs3/fsntfs.c
@@ -944,7 +944,7 @@ int ntfs_set_state(struct ntfs_sb_info *
 	if (!ni)
 		return -EINVAL;
 
-	mutex_lock_nested(&ni->ni_lock, NTFS_INODE_MUTEX_DIRTY);
+	mutex_lock_nested(&ni->ni_lock, (1 + NTFS_INODE_MUTEX_PARENT2));
 
 	attr = ni_find_attr(ni, NULL, NULL, ATTR_VOL_INFO, NULL, 0, NULL, &mi);
 	if (!attr) {
--