linux-kernel - Re: [PATCH] ASoC: cs35l56: Prevent bad sign extension in cs35l56_read_silicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170905021816.83159.8702222315975677755.b4-ty@kernel.org>
Date: Tue, 27 Feb 2024 16:10:18 +0000
From: Mark Brown <broonie@...nel.org>
To: tiwai@...e.com, Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: alsa-devel@...a-project.org, linux-sound@...r.kernel.org, 
 linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Prevent bad sign extension in
 cs35l56_read_silicon_uid()

On Tue, 27 Feb 2024 10:00:42 +0000, Richard Fitzgerald wrote:
> Cast u8 values to u32 when using them to build a 32-bit unsigned value
> that is then stored in a u64. This avoids the possibility of a bad sign
> extension where the u8 is implicitly extended to an int, thus changing it
> from an unsigned to a signed value.
> 
> Whether this is a real problem is debatable, but it does no harm to
> ensure that the u8 are cast to a suitable type for shifting.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l56: Prevent bad sign extension in cs35l56_read_silicon_uid()
      commit: cb9d8a2c6cb7cbb0fc919defe4fae741bfcae9de

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark