linux-kernel - Re: [PATCH v7 00/12] arm64: qcom: add and enable SHM Bridge support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wgvkhq3ljjrwnqiwojvwvjuiiy4o5gfx5bctaklvmpe3v6pusr@6rwtg5npr3au>
Date: Tue, 27 Feb 2024 10:32:05 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Andy Gross <agross@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, Elliot Berman <quic_eberman@...cinc.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Guru Das Srinagesh <quic_gurus@...cinc.com>, 
	Andrew Halaney <ahalaney@...hat.com>, Maximilian Luz <luzmaximilian@...il.com>, 
	Alex Elder <elder@...aro.org>, Arnd Bergmann <arnd@...db.de>, linux-arm-msm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, kernel@...cinc.com, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v7 00/12] arm64: qcom: add and enable SHM Bridge support

On Mon, Feb 19, 2024 at 03:17:24PM +0000, Srinivas Kandagatla wrote:
> On 17/02/2024 19:58, Bjorn Andersson wrote:
> > On Mon, Feb 05, 2024 at 07:27:58PM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > > 
> > > We've established the need for using separate secured memory pools for
> > > SCM and QSEECOM
> > 
> > Where has this need been established, what is the actual problem you're
> > solving with this series?
> 
> SHMbridge will restrict the amount of memory that TZ can see, making system
> more secure.
> 

Then tell me this in the cover letter and commit messages.

> Need for having different pools makes this more scalable overall, so that
> different usecases can run seamlessly. ex: loading a TA and SCM calls.
> 

How is it more scalable to give each "client" a chunk of 256KB instead
of them sharing a pool of ~4GB memory?

> > 
> > Does SCM and QSEECOM, as it's implemented in the kernel today, not work
> > satisfactory?
> > 
> > > as well as the upcoming scminvoke driver.
> > > 
> > 
> > Is smcinvoke driver upstreaming blocked by not transitioning the scm
> > driver to a "secure memory pool"?
> > 
> > Is this happening now, or do we need to merge this series when that day
> > comes?
> 
> SMCInvoke development is happening now, I see no reason for this patchset to
> wait for it.
> 

As presented, I see no reason to merge this series.

> This series can go as it is for two reasons.
> 1> improves system security in general
> 2> Hardware Wrapped key support patches also use this which are also in good
> shape and tested, ready to be merged.
> 

Then tell me this in the cover letter and commit messages!


It's not sufficient that I happen to know the answer to these questions,
neither community nor maintainer should not have to guess these things.

Regards,
Bjorn