[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEnQRZAvqHfNYu+dYObJA=T7S_KfQMxB8TJGmdjK9Ea_FPrLOA@mail.gmail.com>
Date: Tue, 27 Feb 2024 18:29:18 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Javier García <javier.garcia.ta@...ma.es>
Cc: daniel.baluta@....com, broonie@...nel.org, krzysztof.kozlowski@...aro.org,
Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
alsa-devel@...a-project.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, "Damien.Horsley" <Damien.Horsley@...tec.com>
Subject: Re: [PATCH v2] ASoC: dt-bindings: img,spdif-in: Convert to dtschema
On Tue, Feb 27, 2024 at 6:27 PM Daniel Baluta <daniel.baluta@...il.com> wrote:
>
> This looks much better than v1. Make sure you have addressed all
> comments from the previous version
> and add a short log under the scissor line explaining what you have changed.
>
> Few comments inline:
>
>
> On Tue, Feb 27, 2024 at 6:13 PM Javier García <javier.garciata@...ma.es> wrote:
> >
> > Convert the Imagination Technologies SPDIF Input Controllerto DT schema.
> >
> > Signed-off-by: Javier García <javier.garcia.ta@...ma.es>
> > ---
> ^ this is the scissor line. Here you add the change log.
>
> Changes since v1:
> - re-written the subject inline to include relevant prefix
> - removed header file as it is not used
> - ....etc
>
>
> > +$id: http://devicetree.org/schemas/sound/img,spdif-in.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Imagination Technologies SPDIF Input Controller
> > +
> > +maintainers:
> > + - Liam Girdwood <lgirdwood@...il.com>
> > + - Mark Brown <broonie@...nel.org>
>
> Please do not blindly add people here. The most proper candidate for this
> is the people who wrote the original file.
>
> Using git log we can find Damien.Horsley <Damien.Horsley@...tec.com>
Looks like this address bounced back.
@Krzysztof Kozlowski @Mark Brown is it OK to add a mailing list as
maintainer for a yml file?
Powered by blists - more mailing lists