linux-kernel - Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2aaa2a61-f753-4434-8c92-886fc4bb9aef@linuxfoundation.org>
Date: Tue, 27 Feb 2024 09:41:23 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Meng Li <li.meng@....com>, Andrei Vagin <avagin@...gle.com>,
 Huang Rui <ray.huang@....com>, linux-pm@...r.kernel.org
Cc: Nathan Fontenot <nathan.fontenot@....com>,
 Deepak Sharma <deepak.sharma@....com>,
 Alex Deucher <alexander.deucher@....com>,
 Mario Limonciello <mario.limonciello@....com>,
 Perry Yuan <Perry.Yuan@....com>, Xiaojian Du <Xiaojian.Du@....com>,
 Viresh Kumar <viresh.kumar@...aro.org>, Borislav Petkov <bp@...en8.de>,
 linux-kernel@...r.kernel.org,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in
 overlayfs

On 2/27/24 00:42, Meng Li wrote:
> make -C tools/testing/selftests, compiling dev_in_maps fail.
> In file included from dev_in_maps.c:10:
> /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant
>     35 |   MS_RDONLY = 1,                /* Mount read-only.  */
>        |   ^~~~~~~~~
> 
> That sys/mount.h has to be included before linux/mount.h.
> 
> Signed-off-by: Meng Li <li.meng@....com>
> ---
>   tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

I don't see this problem when I build it on my system when
I run:

make -C tools/testing/selftests
or
make -C tools/testing/selftests/filesystems/overlayfs

Are you running this after doing headers_install?

thanks,
-- Shuah