linux-kernel - Re: [PATCH] net: usb: dm9601: fix wrong return value in dm9601_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 17:53:22 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo Abeni
 <pabeni@...hat.com>,  netdev@...r.kernel.org,  linux-usb@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: dm9601: fix wrong return value in
 dm9601_mdio_read

>>>>> "Javier" == Javier Carrasco <javier.carrasco.cruz@...il.com> writes:

 > The MII code does not check the return value of mdio_read (among
 > others), and therefore no error code should be sent. A previous fix to
 > the use of an uninitialized variable propagates negative error codes,
 > that might lead to wrong operations by the MII library.

 > An example of such issues is the use of mii_nway_restart by the dm9601
 > driver. The mii_nway_restart function does not check the value returned
 > by mdio_read, which in this case might be a negative number which could
 > contain the exact bit the function checks (BMCR_ANENABLE = 0x1000).

 > Return zero in case of error, as it is common practice in users of
 > mdio_read to avoid wrong uses of the return value.

 > Fixes: 8f8abb863fa5 ("net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read")
 > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Reviewed-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard