linux-kernel - Re: [PATCH] net: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240227170937.GD277116@kernel.org>
Date: Tue, 27 Feb 2024 17:09:37 +0000
From: Simon Horman <horms@...nel.org>
To: Chengming Zhou <chengming.zhou@...ux.dev>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, vbabka@...e.cz,
	Xiongwei.Song@...driver.com
Subject: Re: [PATCH] net: remove SLAB_MEM_SPREAD flag usage

On Mon, Feb 26, 2024 at 04:55:01PM +0800, Chengming Zhou wrote:
> On 2024/2/24 21:49, chengming.zhou@...ux.dev wrote:
> > From: Chengming Zhou <zhouchengming@...edance.com>
> > 
> > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > its usage so we can delete it from slab. No functional change.
> 
> Update changelog to make it clearer:
> 
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete explicitly to avoid confusion
> for users. Here we can just remove all its users, which has no any
> functional change.
> 
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
> 
> Thanks!
> 
> > 
> > Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

Thanks Chengming Zhou,

this seems reasonable to me. But I think it would be best to post
a v2 of this patch with the updated patch description (which is very
helpful, BTW).

-- 
pw-bot: changes-requested