linux-kernel - RE: [PATCH] dt-bindings: pwm: opencores: Add compatible for StarFive JH8100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 02:01:11 +0000
From: JiSheng Teoh <jisheng.teoh@...rfivetech.com>
To: Conor Dooley <conor.dooley@...rochip.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
CC: Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Paul Walmsley
	<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, William Qiu <william.qiu@...rfivetech.com>, Leyfoon
 Tan <leyfoon.tan@...rfivetech.com>, "linux-pwm@...r.kernel.org"
	<linux-pwm@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>
Subject: RE: [PATCH] dt-bindings: pwm: opencores: Add compatible for StarFive
 JH8100

> On Mon, Feb 26, 2024 at 09:11:23AM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote:
> > > StarFive JH8100 uses the same OpenCores PWM controller as JH7110.
> > > Mark JH8100 as compatible to the OpenCores PWM controller.
> > >
> > > Signed-off-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
> > >
> > > ---
> > >
> > > This patch depends on patch [1] ("dt-bindings: pwm: Add bindings for
> > > OpenCores PWM Controller") in Conor's riscv-dt-for-next branch.
> > > [1]
> > > https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/comm
> > > it/?h=riscv-dt-for-next&id=2529085831b01fcd02ff58ab4e2596d3b31bcf80
> >
> > I recommend to make use of git format-patch's --base parameter to
> > additionally(!) make this information available to the build bots.
> 
> I like the "additionally" :)

Alright, I will take note of that. Thanks 

> >
> > Looks fine to me.
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> >
> > Coner: If you're happy with this patch, please apply it in the same
> > way as the initial OpenCores PWM Controller binding patch.
> 
> Ye, I can do. Although, I suppose this is an example of why the driver maintainers applying the bindings is preferred, even if the driver
> patch itself isn't ready or there is no driver patch.
> 
> Cheers,
> Conor.