[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240227182544.GEZd4pKN5ASvSx4_dO@fat_crate.local>
Date: Tue, 27 Feb 2024 19:25:44 +0100
From: Borislav Petkov <bp@...en8.de>
To: Nikunj A Dadhania <nikunj@....com>
Cc: linux-kernel@...r.kernel.org, thomas.lendacky@....com, x86@...nel.org,
kvm@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
dave.hansen@...ux.intel.com, pgonda@...gle.com, seanjc@...gle.com,
pbonzini@...hat.com
Subject: Re: [PATCH v8 01/16] virt: sev-guest: Use AES GCM crypto library
On Thu, Feb 15, 2024 at 05:01:13PM +0530, Nikunj A Dadhania wrote:
> The sev-guest driver encryption code uses Crypto API for SNP guest
> messaging to interact with AMD Security processor. For enabling SecureTSC,
> SEV-SNP guests need to send a TSC_INFO request guest message before the
> smpboot phase starts. Details from the TSC_INFO response will be used to
> program the VMSA before the secondary CPUs are brought up. The Crypto API
> is not available this early in the boot phase.
>
> In preparation of moving the encryption code out of sev-guest driver to
> support SecureTSC and make reviewing the diff easier, start using AES GCM
> library implementation instead of Crypto API.
>
> Drop __enc_payload() and dec_payload() helpers as both are pretty small and
> can be moved to the respective callers.
>
> CC: Ard Biesheuvel <ardb@...nel.org>
> Signed-off-by: Nikunj A Dadhania <nikunj@....com>
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> Tested-by: Peter Gonda <pgonda@...gle.com>
> ---
> drivers/virt/coco/sev-guest/Kconfig | 4 +-
> drivers/virt/coco/sev-guest/sev-guest.c | 175 ++++++------------------
> drivers/virt/coco/sev-guest/sev-guest.h | 3 +
> 3 files changed, 43 insertions(+), 139 deletions(-)
Acked-by: Borislav Petkov (AMD) <bp@...en8.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists