linux-kernel - Re: [PATCH] mm/cma: convert cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd4xR9sojA-4Mdwm@casper.infradead.org>
Date: Tue, 27 Feb 2024 19:00:23 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Jianfeng Wang <jianfeng.w.wang@...cle.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	akpm@...ux-foundation.org, sidhartha.kumar@...cle.com
Subject: Re: [PATCH] mm/cma: convert cma_alloc() to return folio

On Tue, Feb 27, 2024 at 10:13:38AM -0800, Jianfeng Wang wrote:
> Change cma_alloc() to return struct folio. This further increases the
> usage of folios in mm/hugetlb.

I love the idea, but I don't think this works.  The memory returned
from cma_alloc() isn't set up to be a folio, is it?  That is, it
doesn't have compound_head initialised so that page_folio() on
consecutive pages will return the same pointer.

Or have I misunderstood?