linux-kernel - Re: [PATCH 1/1] mm/khugepaged: keep mm in mm_slot without MMF_DISABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b6b6f11-f9fe-401f-a1c9-0c6074bb5f84@redhat.com>
Date: Tue, 27 Feb 2024 20:18:45 +0100
From: David Hildenbrand <david@...hat.com>
To: Yang Shi <shy828301@...il.com>, Lance Yang <ioworker0@...il.com>
Cc: akpm@...ux-foundation.org, mhocko@...e.com, zokeefe@...gle.com,
 songmuchun@...edance.com, peterx@...hat.com, minchan@...nel.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mm/khugepaged: keep mm in mm_slot without
 MMF_DISABLE_THP check

On 27.02.24 20:13, Yang Shi wrote:
> On Mon, Feb 26, 2024 at 7:51 PM Lance Yang <ioworker0@...il.com> wrote:
>>
>> Previously, we removed the mm from mm_slot and dropped mm_count
>> if the MMF_THP_DISABLE flag was set. However, we didn't re-add
>> the mm back after clearing the MMF_THP_DISABLE flag. Additionally,
>> We add a check for the MMF_THP_DISABLE flag in hugepage_vma_revalidate().
>>
>> Fixes: 879c6000e191 ("mm/khugepaged: bypassing unnecessary scans with MMF_DISABLE_THP check")
> 
> I think Andrew will fold this fix into your original patch.


Unlikely, it's already in mm-stable.

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb