[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1860a754-5cca-4411-904b-ecbe838efa77@ghiti.fr>
Date: Tue, 27 Feb 2024 20:38:40 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Vadim Shakirov <vadim.shakirov@...tacore.com>,
linux-riscv@...ts.infradead.org
Cc: Atish Patra <atishp@...shpatra.org>, Anup Patel <anup@...infault.org>,
Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
<palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Atish Patra <atishp@...osinc.com>
Subject: Re: [PATCH v2,RESEND 1/2] drivers: perf: added capabilities for
legacy PMU
On 27/02/2024 20:26, Alexandre Ghiti wrote:
> On 27/02/2024 18:00, Vadim Shakirov wrote:
>> Added the PERF_PMU_CAP_NO_INTERRUPT flag because the legacy pmu driver
>> does not provide sampling capabilities
>>
>> Added the PERF_PMU_CAP_NO_EXCLUDE flag because the legacy pmu driver
>> does not provide the ability to disable counter incrementation in
>> different privilege modes
>>
>> Suggested-by: Atish Patra <atishp@...osinc.com>
>> Signed-off-by: Vadim Shakirov <vadim.shakirov@...tacore.com>
>> ---
>> drivers/perf/riscv_pmu_legacy.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/perf/riscv_pmu_legacy.c
>> b/drivers/perf/riscv_pmu_legacy.c
>> index 79fdd667922e..a85fc9a15f03 100644
>> --- a/drivers/perf/riscv_pmu_legacy.c
>> +++ b/drivers/perf/riscv_pmu_legacy.c
>> @@ -117,6 +117,8 @@ static void pmu_legacy_init(struct riscv_pmu *pmu)
>> pmu->event_mapped = pmu_legacy_event_mapped;
>> pmu->event_unmapped = pmu_legacy_event_unmapped;
>> pmu->csr_index = pmu_legacy_csr_index;
>> + pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT;
>> + pmu->pmu.capabilities |= PERF_PMU_CAP_NO_EXCLUDE;
>> perf_pmu_register(&pmu->pmu, "cpu", PERF_TYPE_RAW);
>> }
>
>
> I see here that Atish added its RB:
> https://lore.kernel.org/linux-riscv/CAOnJCUJ-eE+zbXH0yBX_QBK2ep779q=wNCSrc+BJfzUb+zBCaw@mail.gmail.com/
>
> So I add it here (hopefully b4 won't complain, I don't know):
FTR, b4 indeed complains:
NOTE: some trailers ignored due to from/email mismatches:
! Trailer: Reviewed-by: Atish Patra <atishp@...osinc.com>
Msg From: Alexandre Ghiti <alex@...ti.fr>
>
> Reviewed-by: Atish Patra <atishp@...osinc.com>
>
> And I'd say the fixes tag for this one is:
>
> Fixes: 9b3e150e310e ("RISC-V: Add a simple platform driver for RISC-V
> legacy perf")
>
> Thanks,
>
> Alex
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Powered by blists - more mailing lists