linux-kernel - Re: [BUG] selftests: cgroup: KMEMLEAK in cgroup/test_cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d1af171a-49e5-4dcb-987c-c41cf166bac1@redhat.com>
Date: Tue, 27 Feb 2024 17:10:22 -0500
From: Waiman Long <longman@...hat.com>
To: Mirsad Todorovac <mirsad.todorovac@....hr>, linux-kernel@...r.kernel.org
Cc: Zefan Li <lizefan.x@...edance.com>, Tejun Heo <tj@...nel.org>,
 Johannes Weiner <hannes@...xchg.org>, Shuah Khan <shuah@...nel.org>,
 cgroups@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 linux-fsdevel@...r.kernel.org
Subject: Re: [BUG] selftests: cgroup: KMEMLEAK in cgroup/test_cpuset_prs.sh

On 2/27/24 14:50, Mirsad Todorovac wrote:
> Hi, everybody,
>
> In the latest vanilla torvalds tree kernel v6.8-rc6-11-g45ec2f5f6ed3 
> on an Ubuntu 23.10 system, there
> KMEMLEAK detected a couple of memory leaks:
>
> Visually it appears like the same leak repeated six times, but I 
> reckoned it might be of importance to
> review them all.
>
> It happened on two boxes, and both have AMD Ryzen processors 7 and 9.
>
> Please find attached the build .config
>
> Best regards,
> Mirsad Todorovac

Yes, you are right. There is a memory leak under certain condition. Will 
post a patch to fix it.

Thanks,
Longman

>
> # cat /sys/kernel/debug/kmemleak [stack decoded]
> unreferenced object 0xffff8d49bd92a720 (size 8):
> comm "test_cpuset_prs", pid 9213, jiffies 4294953562
> hex dump (first 8 bytes):
> 00 00 00 00 00 00 00 00                          ........
> backtrace (crc 0):
> kmemleak_alloc 
> (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045)
> __kmalloc_node 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988)
> alloc_cpumask_var_node 
> (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71)
> cpuset_write_resmask 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:643 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630)
> cgroup_file_write 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092)
> kernfs_fop_write_iter 
> (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334)
> vfs_write 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590)
> ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643)
> __x64_sys_write 
> (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652)
> do_syscall_64 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 
> /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83)
> entry_SYSCALL_64_after_hwframe 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129)
> unreferenced object 0xffff8d49bd92a488 (size 8):
> comm "test_cpuset_prs", pid 9213, jiffies 4294953562
> hex dump (first 8 bytes):
> 00 00 00 00 00 00 00 00                          ........
> backtrace (crc 0):
> kmemleak_alloc 
> (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045)
> __kmalloc_node 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988)
> alloc_cpumask_var_node 
> (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71)
> cpuset_write_resmask 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:646 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630)
> cgroup_file_write 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092)
> kernfs_fop_write_iter 
> (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334)
> vfs_write 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590)
> ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643)
> __x64_sys_write 
> (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652)
> do_syscall_64 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 
> /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83)
> entry_SYSCALL_64_after_hwframe 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129)
> unreferenced object 0xffff8d49bd92a890 (size 8):
> comm "test_cpuset_prs", pid 9213, jiffies 4294953562
> hex dump (first 8 bytes):
> 00 00 00 00 00 00 00 00                          ........
> backtrace (crc 0):
> kmemleak_alloc 
> (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045)
> __kmalloc_node 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988)
> alloc_cpumask_var_node 
> (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71)
> cpuset_write_resmask 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:649 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630)
> cgroup_file_write 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092)
> kernfs_fop_write_iter 
> (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334)
> vfs_write 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590)
> ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643)
> __x64_sys_write 
> (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652)
> do_syscall_64 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 
> /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83)
> entry_SYSCALL_64_after_hwframe 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129)
> unreferenced object 0xffff8d48c12f3720 (size 8):
> comm "test_cpuset_prs", pid 28081, jiffies 4295018483
> hex dump (first 8 bytes):
> 00 00 00 00 00 00 00 00                          ........
> backtrace (crc 0):
> kmemleak_alloc 
> (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045)
> __kmalloc_node 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988)
> alloc_cpumask_var_node 
> (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71)
> cpuset_write_resmask 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:643 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630)
> cgroup_file_write 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092)
> kernfs_fop_write_iter 
> (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334)
> vfs_write 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590)
> ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643)
> __x64_sys_write 
> (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652)
> do_syscall_64 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 
> /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83)
> entry_SYSCALL_64_after_hwframe 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129)
> unreferenced object 0xffff8d48c12f3180 (size 8):
> comm "test_cpuset_prs", pid 28081, jiffies 4295018483
> hex dump (first 8 bytes):
> 00 00 00 00 00 00 00 00                          ........
> backtrace (crc 0):
> kmemleak_alloc 
> (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045)
> __kmalloc_node 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988)
> alloc_cpumask_var_node 
> (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71)
> cpuset_write_resmask 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:646 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630)
> cgroup_file_write 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092)
> kernfs_fop_write_iter 
> (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334)
> vfs_write 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590)
> ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643)
> __x64_sys_write 
> (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652)
> do_syscall_64 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 
> /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83)
> entry_SYSCALL_64_after_hwframe 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129)
> unreferenced object 0xffff8d48c12f3188 (size 8):
> comm "test_cpuset_prs", pid 28081, jiffies 4295018483
> hex dump (first 8 bytes):
> 00 00 00 00 00 00 00 00                          ........
> backtrace (crc 0):
> kmemleak_alloc 
> (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045)
> __kmalloc_node 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 
> /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988)
> alloc_cpumask_var_node 
> (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71)
> cpuset_write_resmask 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:649 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 
> /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630)
> cgroup_file_write 
> (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092)
> kernfs_fop_write_iter 
> (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334)
> vfs_write 
> (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 
> /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590)
> ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643)
> __x64_sys_write 
> (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652)
> do_syscall_64 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 
> /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83)
> entry_SYSCALL_64_after_hwframe 
> (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129)
>
>
>
>